google global: better empty tracker handling#142
Merged
DonSchado merged 8 commits intoDec 8, 2019
Conversation
bumi
approved these changes
Aug 17, 2019
bumi
left a comment
bumi
left a comment
Contributor
There was a problem hiding this comment.
utACK
@DonSchado please merge, if you agree.
| end | ||
| end | ||
|
|
||
| def invalid_tracker? tracker |
Contributor
There was a problem hiding this comment.
I think in the rest of the codebase we use parentheses.
Contributor
|
thanks for the PR! 👍 |
DonSchado
reviewed
Aug 19, 2019
| end | ||
| end | ||
|
|
||
| def invalid_tracker?(tracker) |
Collaborator
There was a problem hiding this comment.
I think that's a very good idea!
But shouldn't we use this chance to give a warning, instead of silently ignoring the tracker? :)
Collaborator
|
ping @glaszig :) is this still relevant? |
and collection logic
glaszig
force-pushed
the
fix/google-global-empty-trackers
branch
from
cf6ad4d to
8412a7e
Compare
Contributor
Author
|
just added the warning. |
Contributor
Author
|
still a blocker? needs improvements? shall i squash the commits? |
Collaborator
|
thanks for the reminder! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
i'm using the following code:
which throws up the following way if
GA_IDis empty:this patch properly handles the case of empty trackers in the templates and deals with a few other cases which should be considered "empty". also caches collected trackers in an ivar to save a few iterations and cleans up the integration test a little.